feat: added loading bars centrally cuz file wise approach resulted in… #34
Conversation
… pytest failing a lot
There was a problem hiding this comment.
Pull Request Overview
This PR attempts to add progress bars using tqdm to various operations in the CLI, but introduces multiple critical bugs that break core functionality. The changes include adding tqdm import, modifying data generation to use a loop, attempting to add progress bars to factor computation, and monkey-patching the VectorizedBacktest.run method.
Key changes attempted:
- Addition of
tqdmprogress bars to data generation, factor computation, and backtesting - Modified data generation to generate symbols one at a time instead of in batch
- Monkey-patched
VectorizedBacktest.runmethod to show progress during backtesting
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/quant_research_starter/cli.py | Adds tqdm import and attempts to integrate progress bars throughout CLI commands, but introduces multiple bugs including broken monkey-patching, incorrect tqdm usage, and performance regressions |
| .gitignore | Adds myenv/ to ignore virtual environment directory |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@Satvik-Singh192 please look into copilot's review and change wherever necessary |
ayushkrtiwari
added
Semver:minor
Satvik-Singh192
force-pushed
the
feat/new-loading
branch
from
fbf25e6 to
77c1988
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
2 participants
… pytest failing a lot
✨ Add tqdm-Based Progress Bars for Long-Running Operations
Closes #32
📝 Description
This PR introduces tqdm-based progress bars to improve user experience during long-running operations such as:
Previously, these steps ran silently, making it difficult for users to estimate how long a process would take. This PR resolves that by adding lightweight progress indicators without altering existing workflows.
✅ Changes Made
1. Synthetic Data Generation
2. Factor Computation
3. Backtest Execution
4. Minimal & Non-Intrusive Changes
[x] I have read the contributing guidelines